[ http://issues.apache.org/jira/browse/DERBY-1651?page=comments#action_12429249 ] Satheesh Bandaram commented on DERBY-1651: ------------------------------------------
Some general comments: 1) I think a design document to explain what each class does and how they interact with each other is required. Other option is to create a package.html file and document design/code in place. I think the second option is better. At the mininum, each class needs a detailed javadoc at the beginning and for each major method. Important and useful contribution like this may not get accepted if not documented properly. 2) Package location needs to be changed. All tools are in org.apache.derby.tools package. Best to follow existing tools like IJ, DBLOOK model so it would be easy to use and to enable derbyrun option for this tool later. 3) Looks like the code uses generics, which limit the use to JDK 1.5 platforms. While this may be ok, need to document need for JDK 1.5 platform and raise appropriate message if used in earlier platforms. Most of derby can still run on JDK 1.3 platforms, though not required for new indepedent modules. 4) There are many areas that need improvements in the code... like exception handling, importing only classes that are needed not the whole package, deleting code that is in comments etc. I understand the code is still in development. I would like to suggest you focus on completing current functionality very well, document what you have done, move code and integrate it at appropriate location and test current functionality before adding more. Better to submit partial code that is well written than submit more code that is not very usable. > Develop a mechanism to migrate mySQL databases to Derby. Migration tool > should include both schema and data migration options. > ------------------------------------------------------------------------------------------------------------------------------ > > Key: DERBY-1651 > URL: http://issues.apache.org/jira/browse/DERBY-1651 > Project: Derby > Issue Type: New Feature > Components: Tools > Environment: All platforms > Reporter: Ramin Moazeni > Assigned To: Ramin Moazeni > Fix For: 10.2.1.0 > > Attachments: DBMigration.diff, MigrationTool-MySQLtoDerby.zip > > > Develop a mechanism to migration databases created by other database engines > to Derby. While my current interest is to migrate mySQL databases to Derby, > the tool could be developed in a way to extend this mechanism to allow > migration from other database engines in the future. > More details of proposed functionality and implementation strategy can be > found at: > http://wiki.apache.org/db-derby/MysqlDerbyMigration > The plan is to develop and submit patches incrementally. First patch supports > migration of tables and views from mySQL database to Derby. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
