Simplify building of SystemColumn array in CatalogRowFactory implementations.
------------------------------------------------------------------------------
Key: DERBY-1734
URL: http://issues.apache.org/jira/browse/DERBY-1734
Project: Derby
Issue Type: Sub-task
Reporter: Daniel John Debrunner
Assigned To: Daniel John Debrunner
Priority: Minor
The implementations of CatalogRowFactory.buildColumnList() can be simplified in
a number of ways:
1) precision & scale are always passed in as zero and can be removed
2) adding static factory methods to SystemColumnImpl would ease the building
of the arrays by not requiring the additional redundant arguments the
constructor call forces today, e.g. max length i snot required to create an
INTEGER column.
3) The column's position is not required to be stored in the SytstemColumn
class, it's defined by the position in the array
4) arrays can be built using
new SystemColumn[] { ... }
syntax instead of the existing
columnList[0] = ...
columnList[1] = ...
or
columnList[index++] = ...
columnList[index++] = ...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
