[ http://issues.apache.org/jira/browse/DERBY-1387?page=comments#action_12429432 ] Andreas Korneliussen commented on DERBY-1387: ---------------------------------------------
Hi, thanks for providing this patch. I have tried compiling it, and I do have the following comments: 1. It seems that most of the classes have multiple entries in the patch file, so when applying the patch, I got the same class multiple times in the same file. 2. After fixing 1, all code, except one class seems to be able to compile with JDK 1.4. The class which depends on JDK 1.5 is BasicManagementService. It uses java.lang.management.ManagementFactory to create the MBeanServer. Instead I would propose simply using javax.management.MBeanServerFactory. This would allow the code to be compiled on JDK 1.4. If you do need the JDK 1.5 libraries, the build files must be set up so that it is still possible to compile on JDK 1.4 (ie. by skipping the JMX targets). > Add JMX extensions to Derby > --------------------------- > > Key: DERBY-1387 > URL: http://issues.apache.org/jira/browse/DERBY-1387 > Project: Derby > Issue Type: New Feature > Components: Services > Reporter: Sanket Sharma > Assigned To: Sanket Sharma > Attachments: derbyjmx.patch, Requirements for JMX Updated.html, > Requirements for JMX.html, Requirements for JMX.zip > > > This is a draft requirement specification for adding monitoring and > management extensions to Apache Derby using JMX. The requirements document > has been uploaded on JIRA as well as the Derby Wiki page at > http://wiki.apache.org/db-derby/_Requirement_Specifications_for_Monitoring_%26_Management_Extensions_using_JMX > Developers and Users are requested to please look at the document (feature > list in particular) and add their own rating to features by adding a coloumn > to the table. > Comments are welcome. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
