[
http://issues.apache.org/jira/browse/DERBY-1618?page=comments#action_12433274 ]
Suresh Thalamati commented on DERBY-1618:
-----------------------------------------
Thanks for working on this bug, Mryna. I briefly looked at the patch,
this issue seems to be related to the DERBY-1296, fix for that seems to have
addressed the problem on jdk14 jvms and above, but not on jvms version before
that.
Following code you copied to DirStorageFactory.java from DirStorageFactor4.java
+ String dir = dataDirectory;
+ if (canonicalName != null && path != null && home != null &&
+ !path.startsWith(home)) {
+ dir = canonicalName;
is not the ideal fix. I think dataDirecroy , should get set to the correct
value in the DirStorageFactory.doInit() throws IOException method.
I think there is also another method in
DirStorageFactory.java/DirStorageFactory4.java,
where the database directory may be set to a wrong value.
StorageFile newPersistentFile( String directoryName, String fileName)
{
return new DirFile( separatedDataDirectory + directoryName, fileName);
}
if the dataDirectory value is wrong for the method you are fixing , I am sure
the above method also will get the wrong path. I think instead of adding checks
for individual methods; dataDirectory should get set to the correct value
in the doInit() method.
Thanks for updating the GetPropertyInfoTest.java to print all the fields.
> store/BootAllTest.junit fails on with jdk13 based jvms
> ------------------------------------------------------
>
> Key: DERBY-1618
> URL: http://issues.apache.org/jira/browse/DERBY-1618
> Project: Derby
> Issue Type: Bug
> Components: Regression Test Failure
> Affects Versions: 10.2.1.0
> Environment: windows. (insane jars) 10.2.0.5 alpha - (426734)
> Reporter: Sunitha Kambhampati
> Assigned To: Myrna van Lunteren
> Fix For: 10.2.1.0
>
> Attachments: DERBY-1618_20060901.diff
>
>
> bootAll test fails on ibm131, wctme5.7.
> ********* Diff file derbyall/storeall/storemore/BootAllTest.diff
> *** Start: BootAllTest jdk1.3.1 storeall:storemore 2006-07-30 06:35:16 ***
> 0 add
> > .F
> > There was 1 failure:
> > 1)
> > testSettingBootAllPropertyWithHomePropertySet(org.apache.derbyTesting.functionTests.tests.store.BootAllTest)junit.framework.AssertionFailedError:
> > The number of databases should be expected:<3> but was:<0>
> > FAILURES!!!
> > Tests run: 1, Failures: 1, Errors: 0
> Test Failed.
> *** End: BootAllTest jdk1.3.1 storeall:storemore 2006-07-30 06:35:35 ***
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
