[ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12434435 ] John H. Embretsen commented on DERBY-1547: ------------------------------------------
No problem... since this is a "time critical" fix, and the sed patterns work (I have not tried the patch yet, though), removing the unnecessary brackets should be optional at this point (I just think it looks clearer without the brackets). So don't let my comment slow down the process to get this fix committed! I have not had time to "interpret" the other patterns fully yet, since I do not know exactly which strings they are supposed to match, and I have other things on my to-do list. But when/if I do, I'll let the community know if I find anything worth mentioning. Thanks for making the patch! > Add svn version number to DatabaseMetaData getDatabaseProductVersion and > getDriverVersion() to improve supportability > ----------------------------------------------------------------------------------------------------------------------- > > Key: DERBY-1547 > URL: http://issues.apache.org/jira/browse/DERBY-1547 > Project: Derby > Issue Type: Improvement > Components: JDBC > Affects Versions: 10.1.3.2 > Reporter: Kathey Marsden > Assigned To: V.Narayanan > Priority: Minor > Fix For: 10.2.1.0 > > Attachments: DERBY-1547-sed-v1.diff, DERBY-1547-sed-v1.stat, > DERBY-1547-sed.diff, DERBY-1547-sed.stat, DERBY-1547_v1.diff, > DERBY-1547_v1.stat, derbyall_fail.txt > > > getDatabaseProductVersion and getDriverVersion() report only the four digit > Derby version number and not the svn build number. It would be useful to > return the full version including the build number as sysinfo does: e.g. > "10.1.2.4 - (392472)", That way it will be clear from application logs that > collect this information exactly what revision level they are running if they > are using rolled up fixes on the maintenance branch between releases. > There may be risk in doing this however if applications are parsing the > version information, but hopefully they will use getDatabaseMajorVersion() , > getDatbaseMinorVersion, getDriverMajorVersion, and getDriverMinorVersion for > such proccessing. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
