[ http://issues.apache.org/jira/browse/DERBY-1718?page=comments#action_12435554 ] A B commented on DERBY-1718: ----------------------------
Thanks for picking this up, figuring out the problem, and providing a fix, Yip! I reviewed the patch and I agree that it's best to write/read the query expression itself instead of reading/writing a Xalan-specific object--so I think you did this the right way. I applied the patch and did a full build with no problems. I also ran the new test case with and without your changes and it behaved as expected--i.e. failed without the patch and passed with it. I then ran the xmlSuite (using ibm142) with these changes applied and I noticed that xml_general.sql fails with DerbyNet and DerbyNet client. Based on your stat file, it looks like only the embedded master file was updated. Can you run the new test with DerbyNet and DerbyNetClient, as well, and update the master files accordingly? One other very minor comment is the age-old comment of whitespace: prior to this patch all lines in SqlXmlUtil.java used 4 spaces, but I see that the diff01 patch introduces tabs. I think it'd be best if you could do a find/replace of tabs with spaces in just the SqlXmlUtil file--since the spacing is uniform in that file already, it'd be nice to keep it that way (even if the whole tab/space issue is still far from resolved for the codeline as a whole). The whitespace isssue is a nit and should not block the patch; I do, however, think that the master updates for DerbyNet and DerbyNetClient should be made before the patch is committed... Note: assuming you have the required classes in your classpath, you can run all of the XML tests against embedded, JCC, and Derby client by running the "xmlSuite" suite. Thanks again for your work on this! > creating an after insert trigger with trigger action involving xml datatype > throws java.io.NottSerializableException > ---------------------------------------------------------------------------------------------------------------------- > > Key: DERBY-1718 > URL: http://issues.apache.org/jira/browse/DERBY-1718 > Project: Derby > Issue Type: Bug > Components: SQL > Affects Versions: 10.3.0.0, 10.2.2.0 > Environment: Java Version: 1.4.2 > Java Vendor: IBM Corporation > Reporter: Suresh Thalamati > Assigned To: Yip Ng > Attachments: derby1718-trunk-diff01.txt, derby1718-trunk-stat01.txt, > stk.txt > > > creating an after insert trigger with trigger action involving xml datatype > throws following error : > ij> create trigger trigxml after insert on t1 for each statement mode db2sql > insert into t2 values (1, > xmlparse(document '<name> ram </name>' preserve whitespace)); > ERROR XSDAJ: Exception during write of a serializable or SQLData object > ERROR XJ001: Java exception: 'org.apache.derby.iapi.types.SqlXmlUtil: > java.io.No > ton'.SerializableExcepti > ij> > repro: > connect 'jdbc:derby:wombat;create=true'; > create table t1 (i int, x xml); > create table t2 (i int, x xml); > insert into t2 values (1, > xmlparse(document '<name> suresh </name>' preserve whitespace)); > --- following trigger creation is failing ,. > create trigger trigxml after insert on t1 for each statement mode db2sql > insert into t2 values (1, > xmlparse(document '<name> ram </name>' preserve whitespace)); -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
