[ http://issues.apache.org/jira/browse/DERBY-1846?page=all ]
John H. Embretsen updated DERBY-1846:
-------------------------------------
Attachment: output_batchFix_v1.txt
derby1846-batchFix_v1.diff
I have also tried the batch script on a Windows XP box. I found four issues:
1)
Missing @echo off - the output is very messy without it
2)
The cleanup command "@erase /s /q %DERBY_HOME%/jdbc4classes" should use a
backslash instead of a forward slash when specifying the jdkc4classes
directory. Here is the output I get with 1) fixed:
"Building Derby client classes for JDBC 4.0"
"Updating
c:\programfiler\derby\sandboxes\bin-10.2.1.3\db-derby-10.2.1.3-bin\lib\derbyclient.jar"
"Building Derby engine classes for JDBC 4.0"
"Updating
c:\programfiler\derby\sandboxes\bin-10.2.1.3\db-derby-10.2.1.3-bin\lib\derby.jar"
"Cleaning up"
Invalid switch - "jdbc4classes".
"Done."
3)
Double quotes around the echo strings are displayed as-is, as shown above.
It looks more professional without them, and it still works (on my machine at
least).
4)
The cleanup command mentioned in 2) does not delete the empty directories
after deleting the JDBC 4 class files. Perhaps the rmdir command works better?
I have attached a patch fixing issues 1), 2) and 3),
'derby1846-batchFix_v1.diff', and the resulting output, output_batchFix_v1.txt
I tested the script by running it from trunk, with DERBY_HOME pointing to a
10.2.1.3-beta installation where I replaced the jars in lib/ with jars from the
trunk, without JDBC 4. I looked for org/apache/derby/.../xxx40.class file
entries in the derby.jar file (jar tf derby.jar), as a preliminary quick check.
I'm sure there are better ways to check whether or not the script was
successful...
> Create a script that allows users to easily update their Derby jars with the
> JDBC4 classes.
> -------------------------------------------------------------------------------------------
>
> Key: DERBY-1846
> URL: http://issues.apache.org/jira/browse/DERBY-1846
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.0
> Reporter: Andrew McIntyre
> Assigned To: Andrew McIntyre
> Fix For: 10.2.1.0
>
> Attachments: derby-1846-v1.diff, derby-1846-v2.diff,
> derby1846-batchFix_v1.diff, output_batchFix_v1.txt
>
>
> Since the resolution of the JDBC 4 licensing issue was to not ship a build
> that includes Derby's JDBC 4 code, but continue to ship the Derby source
> files for them, a script which automatically compiles and updates the Derby
> jars with the JDBC 4 classes would be useful.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
