[ http://issues.apache.org/jira/browse/DERBY-1776?page=all ]

A B updated DERBY-1776:
-----------------------

    Attachment: d1776_reuseInt.patch

In a review comment for a different issue someone mentioned that instead of 
creating new Integer() objects it'd be better to use the Derby ReuseFactory 
where possible to avoid excessive object creation.  I get the feeling that's 
not a big deal with the _v1 patch for this issue, but I nonetheless thought 
it'd be a good idea to follow that advice with the changes.

So I'm attaching a tiny patch, d1776_reuseInt.patch, that replaces the calls to 
"new Integer()" in the _v1 patch (which has already  been committed) with calls 
to ReuseFactory.getInteger().  Functionally, the patch doesn't change anything.

I ran xmlSuite on Windows 2000 with ibm142 and all tests passed.

> ERROR 42Z72: XML syntax error; missing keyword(s): 'AS'. - Misleading text
> --------------------------------------------------------------------------
>
>                 Key: DERBY-1776
>                 URL: http://issues.apache.org/jira/browse/DERBY-1776
>             Project: Derby
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 10.2.1.0, 10.3.0.0
>            Reporter: Daniel John Debrunner
>         Assigned To: A B
>            Priority: Minor
>             Fix For: 10.2.1.0, 10.3.0.0
>
>         Attachments: d1776_reuseInt.patch, d1776_v1.patch
>
>
> create table t (i int, x xml);
> select xmlserialize(x) from t;
> ERROR 42Z72: XML syntax error; missing keyword(s): 'AS'.
> This is not an 'XML Syntax error', it's a syntax in the SQL language. No need 
> to have a special error messgae here, wouldn't the error be caught by regular 
> parsing?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to