[ 
http://issues.apache.org/jira/browse/DERBY-1839?page=comments#action_12437879 ] 
            
A B commented on DERBY-1839:
----------------------------

I reviewed the changes and they look great to me.  Only two very (very) minor 
suggestions that would be nice:

-- 1--

rreffuncxmlquery:

Perhaps a slight rewording here: can we replace "has" with "have" and then 
change the last part of the following the sentence?

 The result set for this query contains a row for only the rows in x_table that 
has a student name of BC.

to be:

 The result set for this query contains a row for only the rows in x_table that 
have at least one
 student whose name is BC.

-- 2 --

rreffuncxmlserialize:

Very slight rewording: maybe replace "contents" with "type" in the following 
sentence:

 There is no other way to convert the contents of a Derby XML value.

I think it's more accurate to say that we convert the type than it is to say 
that we convert the contents...

I did notice that "data type" is still in the title of the rrefsqljtypexml.html 
 page even though Jean had suggested that it be removed...but I'll let Jean 
comment on that if she's so inclined :) 

Thanks Laura.

> Doc Review Updates - Ref Manual
> -------------------------------
>
>                 Key: DERBY-1839
>                 URL: http://issues.apache.org/jira/browse/DERBY-1839
>             Project: Derby
>          Issue Type: Improvement
>          Components: Documentation
>    Affects Versions: 10.2.2.0
>            Reporter: Laura Stewart
>         Assigned To: Laura Stewart
>             Fix For: 10.2.1.5, 10.3.0.0
>
>         Attachments: 1839_SQLstatements.diff, derby1839_SQLstatement_4.diff, 
> derby1839_SQLstatements2.diff, derby1839_SQLstatements2_html.zip, 
> derby1839_SQLstatements3.diff, derby1839_SQLstatements3_html.zip, 
> derby1839_SQLstatements4_html.zip, derby1839_SQLstatements_html.zip, 
> derby1839_TANCEILfunctions.diff, derby1839_TANCEILfunctions_html.zip, 
> derby1839_XML+functions_1.diff, derby1839_XML+functions_html1.zip
>
>
> This JIRA issue will be used to track all of the issues found in the 10.2 doc 
> review of the Reference Manual.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to