[ http://issues.apache.org/jira/browse/DERBY-1872?page=comments#action_12438363 ] John H. Embretsen commented on DERBY-1872: ------------------------------------------
Hi Andrew, thanks for looking at this... As far as I know there are no failures on 10.1 that this patch will fix. Hopefully it won't introduce any either... but wisconsin is still a bit unstable in trunk (DERBY-1801), so you never know. But yes, the main point of this patch is just so that memory profiling using this test is more consistent across branches. Here's some history that may help you understand the background for this patch: I ported the 10.2.0.4 wisconsin test to the 10.1 branch so that I could have a better foundation for determining whether or not DERBY-1564 was a 10.2 regression or not. Since I already had a patch for porting the test, Kathey (Marsden) asked me to submit it so that it could be committed to the 10.1 branch. That is what I did, after polishing it just a bit. So I leave it to you and Kathey (and other interested parties, if any) to decide whether or not to commit the patch. Yes, I agree that porting DERBY-1091 and DERBY-1614 to 10.1 would be good, but I have been reluctant to look into that too closely, since I fear that would open up another can of worms. Right now the jvmflags are not passed properly from the test _app.properties files in 10.1, but it seems to be possible to set a specific heap size at least, using the jvmflags property from the command line. > Backport lang/wisconsin.java at 10.2.0.4-alpha to the 10.1 branch > ----------------------------------------------------------------- > > Key: DERBY-1872 > URL: http://issues.apache.org/jira/browse/DERBY-1872 > Project: Derby > Issue Type: Test > Components: Test > Affects Versions: 10.1.3.1 > Environment: N/A > Reporter: John H. Embretsen > Assigned To: John H. Embretsen > Priority: Minor > Fix For: 10.1.3.2 > > Attachments: port-wisconsin-from-10.2.0.4-to-10.1_v2.stat, > port-wisconsin-from-10.2.0.4-to-10.1_v2.zip > > > Investigations relating to DERBY-1564 ("wisconsin.java test failed in > DerbyNet or DerbyNetClient frameworks, VM for network server got > OutOfMemoryError") revealed that comparing memory usage for the > lang/wisconsin.[java|sql] test in 10.1.x versus 10.2.x was like comparing > apples and oranges. After the 10.1 branch was created, several updates were > made to the wisconsin test in trunk that were not backported to 10.1, e.g: > * giving the optimizer unlimited time to choose query plans > * compressing the tables to avoid the instabilities reported in DERBY-937 > Backporting the test will make it less unfair to compare 10.1 vs. 10.2 (or > trunk) test results and memory usage, and it will make it easier to determine > if failures (such as DERBY-1564) are regressions or not. On the other hand, > other differences between the branches that may influence the test will > remain, so this will not be a wonder cure. > The failures seen in DERBY-1564 were mainly caused by bugs (DERBY-1091, > DERBY-1614) in the test harness, causing the wisconsin test for the 10.2.0.4 > snapshot to run with low memory settings. These issues have been fixed. > The most practical backporting approach will probably be to take the > wisconsin test as it was in the 10.2.0.4-snapshot (SVN revision 423199), and > port it to the current 10.1 branch. Other changes have been made to the > wisconsin test in trunk/10.2 after 10.2.0.4, but to avoid various > dependencies (e.g. DERBY-1609), these should not be backported. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
