[ http://issues.apache.org/jira/browse/DERBY-1489?page=comments#action_12439662 ] Mamta A. Satoor commented on DERBY-1489: ----------------------------------------
I just finished reviewing the patch. It looks great, especially the comments in the code and in the tests. Will be very beneficial to next person in the line. My only feedback is do we have a jira entry for doc changes that need to go for this feature? It will be very helpful to outline how for instance unnamed NOT NULL constraint will not block DROP COLUMN RESTRICT, but an explicitly named CHECK constraint will blcok DROP COLUMN RESTRICT. Similarly, the behavior of indexes and DROP COLUMN RESTRICT should be documented. In short, what would block a RESTRICT and what would be allowed to pass through should be clearly documented so users are aware of the expected behavior. Other than that, thumbs up for this patch. Great Job. > Provide ALTER TABLE DROP COLUMN functionality > --------------------------------------------- > > Key: DERBY-1489 > URL: http://issues.apache.org/jira/browse/DERBY-1489 > Project: Derby > Issue Type: New Feature > Components: Documentation, SQL > Affects Versions: 10.0.2.0, 10.0.2.1, 10.1.1.0, 10.2.1.6, 10.1.2.1, > 10.1.3.0, 10.1.3.1 > Reporter: Bryan Pendleton > Assigned To: Bryan Pendleton > Attachments: drop_column_v5_grant_tests.diff, > drop_column_v6_grant_not_implemented.diff, > drop_column_v7_suggestions_from_mamta.diff, > drop_column_v8_restored_tests.diff, dropColumn_2.diff, > dropColumn_v3_view_drop.diff, dropColumn_v4_grant_tests.diff > > > Provide a way to drop a column from an existing table. Possible syntax would > be: > ALTER TABLE tablename DROP COLUMN columnname CASCADE / RESTRICT; > Feature should properly handle columns which are used in constraints, views, > triggers, indexes, etc. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
