[ http://issues.apache.org/jira/browse/DERBY-2042?page=comments#action_12448072 ] Knut Anders Hatlen commented on DERBY-2042: -------------------------------------------
Thanks Bryan, the changes look great! One last comment. I looked at how the page for CREATE INDEX defined the syntax. It doesn't mention schema name in the syntax description, but table-Name is a hyperlink to a page which defines table-Name as [ schemaName. ] SQL92Identifier. Also, I started wondering whether it is correct to use "new-Column-Name" in the syntax. Perhaps it is more semantics than syntax. I think we could write the syntax this way (with hyperlinks to the definitions of table-Name and Simple-column-Name): RENAME COLUMN table-Name.Simple-column-Name TO Simple-column-Name And a final nit: In the text that explains the examples, the identifiers "manager", "employee" and "supervisor" are written in plain text with no quotation marks, but "c1" and "t" are written in double quotes. Perhaps the DITA experts know a markup tag which could be used to consistently mark identifiers? > Provide documentation for new RENAME COLUMN statement > ----------------------------------------------------- > > Key: DERBY-2042 > URL: http://issues.apache.org/jira/browse/DERBY-2042 > Project: Derby > Issue Type: Improvement > Components: Documentation > Affects Versions: 10.3.0.0 > Reporter: Bryan Pendleton > Assigned To: Bryan Pendleton > Priority: Minor > Attachments: renameColumnDoc_v1.diff, renameColumnDoc_v2.diff, > rrefsqljrenamecolumnstatement.html, rrefsqljrenamecolumnstatement.html > > > DERBY-1490 proposes to add a new RENAME COLUMN statement. Assuming that such > a statement is added, we need to update the documentation to describe this > new statement. DERBY-1490 describes the behavior of the statement in detail; > this issue is just to track the documentation, which I intend to address > separately after the DERBY-1490 changes are committed. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
