Mike Matrigali <[EMAIL PROTECTED]> writes:
> It would be fine to use an unchecked and/or an ASSERT based check for > readFieldLengthAndSetStreamPosition. The "store" module owns this > access and is not counting on limit checks to catch anything here. Another question: All observed calls to setLimit (single tuple select load) come from the same method: StoredPage.readRecordFromArray(...) (setLimit is also called from readRecordFromStream() but this does not seem to happen with this type of load) And the argument to setLimit()is always the local variable fieldDataLength which is the return value from StoredFieldHeader.readLengthAndSetStreamPosition(). So if readLengthAndSetStreamPosition() can update the position without checking, presumably the return value from this method can be trusted as well? Is it then necessary to check this value again in setLimit(), or could we have used an unchecked version of setLimit here? -- dt
