[ http://issues.apache.org/jira/browse/DERBY-2161?page=all ]

Andrew McIntyre updated DERBY-2161:
-----------------------------------

    Attachment: derby-2161-v1.diff

Probably didn't need to pass the properties object around from method to 
method, just have one properties object for the instance. Now that I think 
about it, multiple languages would be handled at the Ant level, not in 
MessageBuilder, so there's unlikely to be multiple Properties objects in a 
single MessageBuilder. I can remove the passing of the Properties object around 
if anyone objects.

> MessageBuilder can write the properties file using the wrong encoding.
> ----------------------------------------------------------------------
>
>                 Key: DERBY-2161
>                 URL: http://issues.apache.org/jira/browse/DERBY-2161
>             Project: Derby
>          Issue Type: Bug
>          Components: Build tools
>    Affects Versions: 10.3.0.0
>            Reporter: Daniel John Debrunner
>             Fix For: 10.3.0.0
>
>         Attachments: derby-2161-v1.diff
>
>
> MessageBuilder  uses java.io.FileWriter to write the properties files which 
> picks up the default encoding, but properties files have a defined encoding 
> ISO 8859-1 with unicode esacape sequences. I don't see anything in the 
> build.xml that forces the encoding or  when running the task. Also I don't 
> see any code that implements Unicode escapes.
> I think a better approach would be to use the Properties class to write the 
> properties file, then we don't have to try and maintain the same logic for 
> formatting the output file.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to