[ http://issues.apache.org/jira/browse/DERBY-2152?page=all ]
A B updated DERBY-2152:
-----------------------
Derby Info: (was: [Patch Available])
> I think the schema name for the function will always be passed in,
> even if it isn't explicitly set in the SQL statement.
Yes, you're right. In cases where the schema isn't explicitly specified the
code will simply pass the current schema name to the DataDictionary. In
NewInvocation.java:
+ /* If no schema was specified then we want to default to the
+ * current schema; that's what the following line does.
+ */
+ String funcSchema =
+ getSchemaDescriptor(funcName.getSchemaName()).getSchemaName();
So I removed the words "if specified" from the javadoc comment. Thank you for
pointing this out.
> Once the code has been committed maybe some cleanup could be done,
> could be the old code to match the new code, or some other common
> ground.
Good idea, thank you for bringing this up. I committed the _v2 patches (after
updating the javadoc as mentioned above) with svn revision #488827. I'll look
at creating a follow-up patch to make the two getVTIClassFor* methods more
consistent with each other. That said, I'm leaving town tomorrow so I probably
won't be posting any follow-up patches until January...
Thank you for the review!
> Support diagnostic vti tables that take parameters, such as SpaceTable
> ----------------------------------------------------------------------
>
> Key: DERBY-2152
> URL: http://issues.apache.org/jira/browse/DERBY-2152
> Project: Derby
> Issue Type: Improvement
> Components: SQL
> Reporter: Daniel John Debrunner
> Assigned To: A B
> Attachments: d2152_engine_v1.patch, d2152_engine_v2.patch,
> d2152_testing_v1.patch, d2152_testing_v2.patch, d2152_v1.stat, d2152_v2.stat
>
>
> Expand the work of DERBY-571 to support the remaining diagnostic tables that
> take parameters.
> Syntax would use the table constructor, like (not sure if an 'AS' clause will
> be required:
> select * from TABLE(SYSCS_DIAG.SPACE_TABLE(?, ?))
> Diagnostic VTIs that could be handled this way are:
> ErrorLogReader(String log file name)
> SpaceTable(String tableName)
> SpaceTable(String schemaName, String tableName)
> StatementDuration(String inputFileName)
> This is the second stage mentioned in DERBY-571
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
