[ https://issues.apache.org/jira/browse/DERBY-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen resolved DERBY-2226. --------------------------------------- Resolution: Fixed Fix Version/s: 10.3.0.0 Thank you for addressing my comments, Dyre. Patch v2 looks good. Committed revision 496645. > Move column bitset computation to IndexToBaseRowNode > ---------------------------------------------------- > > Key: DERBY-2226 > URL: https://issues.apache.org/jira/browse/DERBY-2226 > Project: Derby > Issue Type: Improvement > Reporter: Dyre Tjeldvoll > Assigned To: Dyre Tjeldvoll > Priority: Trivial > Fix For: 10.3.0.0 > > Attachments: derby-2226.v1.diff, derby-2226.v1.stat, > derby-2226.v2.diff, derby-2226.v2.stat > > > The constructor for IndexRowToBaseRowResultSet > takes a bitset describing the columns coming from the heap and a > bitset describing the columns coming from the index. But in every > IndexRowToBaseRowResultSet one also has to compute _all_ referenced > columns (union of heap and index bitsets), and frequently also those > columns _only_ coming from the heap (set difference between heap and > index). > But the value of these "set products" seem _only_ to depend on objects > that are fixed at compile time (in IndexToBaseRowNode), so it would be > cleaner (and possibly more efficient) to compute these products there. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira