[
https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466007
]
Dyre Tjeldvoll commented on DERBY-2191:
---------------------------------------
Attached another patch (bitops.v1) which changes the bitset operator methods
or(), and() and xor() so that they follow the same pattern. That is; they all
accept null as an argument and treats that as an empty bitset, and they all
allow operands of all sizes and handles them the same way. All are now
performing the operation bytewise, and there is no special handling of the last
partial byte. The patch also adds a method called invariantHolds() that checks
if the class' invariant is maintained (for use in the unit test).
> Cleanup of FormatableBitSet
> ---------------------------
>
> Key: DERBY-2191
> URL: https://issues.apache.org/jira/browse/DERBY-2191
> Project: Derby
> Issue Type: Improvement
> Components: Miscellaneous
> Affects Versions: 10.2.1.6
> Reporter: Dyre Tjeldvoll
> Assigned To: Dyre Tjeldvoll
> Priority: Trivial
> Fix For: 10.3.0.0
>
> Attachments: bitops.v1.diff, bitops.v1.stat, boundarycheck.v1.diff,
> boundarycheck.v1.stat, cleanup2191.diff, cleanup2191.stat, deadcode.v1.diff,
> deadcode.v2.diff, fbstst.v1.diff, fbstst.v1.stat, FormatableBitSetTest.java,
> unusedmethods.v1.diff, unusedmethods.v1.stat, valuenotnull.v1.diff,
> valuenotnull.v1.stat
>
>
> The implementation of FormatableBitSet could be streamlined. Dead code can be
> removed and the implementation of some methods can be simplified.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
