[
https://issues.apache.org/jira/browse/DERBY-2095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466200
]
Sunitha Kambhampati commented on DERBY-2095:
--------------------------------------------
Thanks very much Dan for your review comments. I am glad you caught the 0 and 1
based inconsistency.
I am attaching a patch (derby2095.p2.diff.txt) that incorporates the review
comments, cleanup, and also adds some tests for consistency checks.
Details are as follows:
1) Add a new class Checks. This class has fixtures to test for rowcounts, as
well as the consistency checks mentioned in Section 3.3.2.1 to 3.3.2.4 of TPC-C
specification.
2) Cleanup Load interface to remove the single table loads
3) Remove LoadTester as it is no longer needed
4) Push fixtures to test the rowcounts to the Checks class from the
OETest.OETest as well as the Populate test call test fixtures from Checks class.
6) Remove SimpleInsert(Connection,short) constructor as it is no longer needed.
7) Changes in SimpleInsert to make all tables 1 based.
8) Add a new Test Class -Schema to load the schema and cleanup code in OETest
and Populate.
Also note:
-- Now that OETest will call the Schema fixtures to run the test, there will be
output printed on System.out for the performance response time numbers for the
schema creation also.
-- With this set of cleanup, SimpleInsert object in setUp of Populate will only
be created once, for the load test which is required.
__________________________
To run the test, its the same command as before. Now there will be 4 more tests
run that includes the consistency conditions 1 to 4 if you enable the doChecks
option.
Some e.g
//scale 1
java org.apache.derbyTesting.system.oe.run.Populate
java org.apache.derbyTesting.system.oe.run.Populate -scale 2 -doChecks false
-createConstraintsBeforeLoad false
svn stat:
M java\testing\org\apache\derbyTesting\system\oe\load\SimpleInsert.java
M java\testing\org\apache\derbyTesting\system\oe\test\OETest.java
D java\testing\org\apache\derbyTesting\system\oe\test\LoadTester.java
A java\testing\org\apache\derbyTesting\system\oe\run\Checks.java
A java\testing\org\apache\derbyTesting\system\oe\run\Schema.java
M java\testing\org\apache\derbyTesting\system\oe\run\Populate.java
M java\testing\org\apache\derbyTesting\system\oe\client\Load.java
Can someone please review this patch. Thanks.
> Add the ability to populate a database for the order entry toolkit based upon
> the TPC-C specification.
> ------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2095
> URL: https://issues.apache.org/jira/browse/DERBY-2095
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Reporter: Daniel John Debrunner
> Assigned To: Sunitha Kambhampati
> Priority: Minor
> Attachments: derby2095.p2.diff.txt, oe.load.p1.diff.txt
>
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
