[ 
https://issues.apache.org/jira/browse/DERBY-2087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466772
 ] 

Daniel John Debrunner commented on DERBY-2087:
----------------------------------------------

I'm planning on committing this today. The comments in 
TestConfiguration.openDatabase(String databaseName) need a little cleanup.
  1) It opens the specified database not the default database
  2) Some comment about requiring a singleUseDatabase decorator should be added
 
I'll add these in the commit.

Putting the single use databases in the singleUse folder could be a follow on 
patch. It seems like it would make the usage consistent with the default case 
and with the folder usage described in

http://wiki.apache.org/db-derby/DerbyJunitTestConfiguration#head-af5a240fccda5c96f104776dfbd20a8cabde55e0

It would also allow the database names to be unique thus allowing the potential 
for tests to be run in parallel rather than limited to being single thread by a 
fixed database name.

Of course the api would need some thinking out in terms of how 
TestConfiguration.openDatabase(String databaseName) works, but it could be 
TestConfiguration automatically provides a mapping between the logical name 
"DB1" and the actual name in use  "singleUse/oneUse42".

> Clean up of a database server directory after running junit tests.
> ------------------------------------------------------------------
>
>                 Key: DERBY-2087
>                 URL: https://issues.apache.org/jira/browse/DERBY-2087
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.3.0.0
>            Reporter: Julius Stroffek
>         Assigned To: Julius Stroffek
>            Priority: Minor
>             Fix For: 10.3.0.0
>
>         Attachments: d2087.diff, d2087.stat, d2087_try2.diff, d2087_try2.stat
>
>
> If I create a test using multiple connections using code like this 
>       DataSource ds1 = JDBCDataSource.getDataSource("FIRSTDB1");
>       JDBCDataSource.setBeanProperty(ds1, "connectionAttributes", 
> "create=true");
>       Connection conn1 = ds1.getConnection();
> the files created on a server does not get cleaned.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to