[ 
https://issues.apache.org/jira/browse/DERBY-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mamta A. Satoor updated DERBY-1275:
-----------------------------------

    Attachment: DERBY1275EnableClientTracingStatV3.txt
                DERBY1275EnableClientTracingDiffV3.txt

I have attached a new patch DERBY1275EnableClientTracingDiffV3.txt which is 
based on Dan's comments on the earlier patch.

What's different(high level)  from the last patch 
(DERBY1275EnableClientTracingDiffV2.txt) 

Junit test
1)The suite method now uses a decorator to set the system properties.
2)The client tracing directory cleanup before the fixture testConnection is 
done is setUp and cleanup after the test is done in tearDown.
3)The assert is now done in the fixture, testConnection.
4)The junit class now ends with Test. The new name of the test is 
ClientSideSystemPropertiesTest.

Code related to privilege block
1)I have replaced the new classes for privilege blocks with anonymous inline 
classes.
2)I hope that I have addressed the exception code related to 
PrivilegedActionException correctly.
3)I have removed the synchronized from run() methods. I have to admit that I 
had them originally because some existing junit test had them(I don't remember 
offhand what test I checked).

I have run the junit suite and there was no new errors.

> Provide a way to enable client tracing without changing the application
> -----------------------------------------------------------------------
>
>                 Key: DERBY-1275
>                 URL: https://issues.apache.org/jira/browse/DERBY-1275
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Client
>    Affects Versions: 10.1.3.1, 10.2.1.6
>            Reporter: Kathey Marsden
>         Assigned To: Mamta A. Satoor
>            Priority: Minor
>             Fix For: 10.2.3.0
>
>         Attachments: DERBY1275EnableClientTracingDiffV1.txt, 
> DERBY1275EnableClientTracingDiffV2.txt, 
> DERBY1275EnableClientTracingDiffV3.txt, 
> DERBY1275EnableClientTracingStatV1.txt, 
> DERBY1275EnableClientTracingStatV2.txt, DERBY1275EnableClientTracingStatV3.txt
>
>
> Currently  the client tracing can be enabled by  setting attributes on the 
> client url, setXXX methods on the DataSource or calling 
> DriverManager.setLogWriter(), but it often cannot be enabled in a deployed 
> client application  because all of these API's require modification of the 
> application or its configuration files.
> It would be good to have a global way to turn on client tracing.  A system 
> property pointing to a property file is  one possibility but probably not 
> ideal because of the impact in class loader contexts.    I am not sure what 
> the other possiblities are,

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to