[
https://issues.apache.org/jira/browse/DERBY-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470499
]
Kristian Waagan commented on DERBY-1709:
----------------------------------------
I have read the text and briefly looked at the diff. I have not done a complete
review.
My comments:
- a little noise due to missing newline in some files (a nit, editor
"artifact")
- in frameworks.DEPRECATED:
a) Strange sentence?
"An alternative to using the set*CP scripts is to add derbyrun.jar from
the Derby distribution to your classpath will put all of the Derby classes into
your classpath."
b) Missing space: PROTOCOLcommand
c) A few long lines.
I tried the scripts on Solaris to confirm that the notice is displayed, and it
is.
However, when not run from the directory where the scripts is located, the
notice script is not found.
For UNIX this can easily be solved by using ". `dirname
$0`/../../deprecated_notice.ksh". Don't know for Windows.
Is this worth fixing?
The script will of course still fail if it is moved (and the other one is not).
> Deprecate scripts in frameworks directory
> -----------------------------------------
>
> Key: DERBY-1709
> URL: https://issues.apache.org/jira/browse/DERBY-1709
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.6
> Reporter: Andrew McIntyre
> Assigned To: Andrew McIntyre
> Fix For: 10.2.3.0
>
> Attachments: derby-1709-code-v1.diff
>
>
> With revision 432159, new scripts to be added to the -bin distribution as a
> part of DERBY-1032 were added to the distributions and snapshots. The old
> frameworks scripts should be marked as deprecated where appropriate in the
> documentation, readme files, and release pages.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
