[ 
https://issues.apache.org/jira/browse/DERBY-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew McIntyre updated DERBY-1709:
-----------------------------------

    Attachment: derby-1709-code-v2.diff

Thanks for the review, Kristian!

I'm leaving the one DERBY_OPTS line long because there's no good cross-platform 
way to show it broken.

Not sure about the line endings, everything should be Unix line-endings in the 
text file, proper line-endings per platform in the various scripts. Thanks for 
mentioning it, though, I've added frameworks.DEPRECATED.txt to the list of 
files that get the line-ending treatment at release time.

Addressed the other comments as well. Got rid of the separate deprecation 
warning notice script and just put the warning into each file. 

If there are no further comments, I will commit this in a day or two, and will 
verify line-endings on batch files are still correct after commit.


> Deprecate scripts in frameworks directory
> -----------------------------------------
>
>                 Key: DERBY-1709
>                 URL: https://issues.apache.org/jira/browse/DERBY-1709
>             Project: Derby
>          Issue Type: Improvement
>          Components: Demos/Scripts
>    Affects Versions: 10.2.1.6
>            Reporter: Andrew McIntyre
>         Assigned To: Andrew McIntyre
>             Fix For: 10.2.3.0
>
>         Attachments: derby-1709-code-v1.diff, derby-1709-code-v2.diff, 
> DERBY-1709-doc.diff, DERBY-1709-doc.zip
>
>
> With revision 432159, new scripts to be added to the -bin distribution as a 
> part of DERBY-1032 were added to the distributions and snapshots. The old 
> frameworks scripts should be marked as deprecated where appropriate in the 
> documentation, readme files, and release pages.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to