[ 
https://issues.apache.org/jira/browse/DERBY-2304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12471570
 ] 

Myrna van Lunteren commented on DERBY-2304:
-------------------------------------------

I looked at patch 3 and have 2 comments related to running with j2ME...

- the test proc  updateLongVarbinaryProc (byte[] in_param) uses 
   Connection conn = DriverManager.getConnection("jdbc:default:connection");
  Used in testUpdateLongBinaryProc.
  I am wondering if it is possible to change this to not use DriverManager.
  If that were possible, that subtest theoretically could run in j2ME 
environment, I think.

- because of the call to cs.getBigDecimal() in testBigDecimalInAndOutParameters 
that subtest will fail with JSR169/j2ME.

If the subtests that fail for the reasons above could get a if 
(!JDBC.vmSupportsJSR169()) block, then this test can be added where it is in 
jdbcapi._Suite.java; otherwise, it the entire test needs to be only added if 
the jvm is not one supporting only JSR169.

For the rest, this looks good to me, and passes for me with jdk14.

Myrna

> Convert derbynet/callable.java to junit
> ---------------------------------------
>
>                 Key: DERBY-2304
>                 URL: https://issues.apache.org/jira/browse/DERBY-2304
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>            Reporter: Jean T. Anderson
>         Assigned To: Jean T. Anderson
>            Priority: Minor
>         Attachments: derby-2304-preview-2.diff, derby-2304-preview-3.diff, 
> derby-2304-preview.diff
>
>
> Convert the derbynet.callable.java test to the junit framework.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to