[
https://issues.apache.org/jira/browse/DERBY-2334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473858
]
Daniel John Debrunner commented on DERBY-2334:
----------------------------------------------
I think the BaseMonitor is the incorrect location for checking and setting the
collation. I can see why you put it there, to match territory, but territory is
an attribute that affects the whole system, such as all error messages.
Collation is limited to the SQL subsystem though, much like the handling the
log_device is limited to the store code. I think the code related to collation
should be in the data dictionary. I think this would mean that the collation
setting would be stored as a database property and not in service.properties, I
think that means the same api, just not adding the name for the collation
property into the list in PropertyUtil.
Two other thoughts;
Having the database property being different to the JDBC attribute might be
a good idea, e.g. derby.database.collation, like territory is not stored using
territory, but derby.serviceLocale. I'll try & remember why I think this is a
better model. :-)
The name TERRITORY_BASED_COLLATION is somewhat awkward. Since it's being set
using collation=TERRITORY_BASED_COLLATION it doesn't really need the
_COLLATION. It would good for the term to be something that described how the
collation was being done, not what other attribute it is based upon. I wonder
if there is a standard term for this, UNICODE might be it from SQL Standard
(and UniCode10) but more checking is needed. I wonder if Java defines its
locale based collators in terms of any standard terms. The code can proceed
with the current term, but it might be good to change it before 10.3 is
released.
> Accept the new collation attribute and store it in services.properties file.
> Will be used for language based collation ordering.
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2334
> URL: https://issues.apache.org/jira/browse/DERBY-2334
> Project: Derby
> Issue Type: Sub-task
> Components: JDBC
> Affects Versions: 10.3.0.0
> Reporter: Mamta A. Satoor
> Assigned To: Mamta A. Satoor
> Attachments: DERBY2334_AcceptCollationAttribute_diff_V01.txt,
> DERBY2334_AcceptCollationAttribute_stat_V01.txt
>
>
> A user would specify the collation desired (UCS_BASIC or
> TERRITORY_BASED_COLLATION) through the new jdbc url attribute - collation.
> This attribute will be used to determine collation ordering for character
> datatypes,
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
