[
https://issues.apache.org/jira/browse/DERBY-2356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12474512
]
Kristian Waagan commented on DERBY-2356:
----------------------------------------
Just a few quick comments!
1) Typo in Property.java
[drda.NaiveTrustManager]
2) Strange sentence in JavaDoc for getSocketFactory()
3) No JavaDoc for the other methods. Are these documented elsewhere? For
instance, what form/value is authType supposed to have?
4) Could getAcceptedIssuers() return an empty array instead of null?
[NetworkServerControlImpl]
5) I guess SSL_OFF and default are the same for now. It would be nice with a
comment to document the fall-through.
6) Long line/missing newline in getSSLModeValue
[net.NaiveTrustManager]
7) See items 2-4.
[NetConnection]
8) Several long lines. Was long before, but maybe it is possible to break some
of them?
[OpenSocketAction]
9) Document fall-through in switch?
There also seems to be a mix of tabs and spaces in the changed code. Even
though the code already contains both, it would be nice to stick to one
alternative when adding/changing lines.
I'll give the functionality a try tomorrow!
Thanks,
> Make SSL server authentication optional
> ---------------------------------------
>
> Key: DERBY-2356
> URL: https://issues.apache.org/jira/browse/DERBY-2356
> Project: Derby
> Issue Type: Improvement
> Components: Network Client, Network Server
> Affects Versions: 10.3.0.0
> Reporter: Bernt M. Johnsen
> Assigned To: Bernt M. Johnsen
> Fix For: 10.3.0.0
>
> Attachments: derby-2356-v1.diff, derby-2356-v1.stat, SSLFuncSpect.txt
>
>
> Default SSL behaviour is to require serer authentication. For a database
> application this is not as important as it is for web browsers and also
> creates som extra hassle for the user/application programmer. Since the main
> objective for SSL in Derby is encryption on the wire, server authentication
> should be optional (the same way client authentication is).
> This also creates some symmetry which can be exploited to simplify the user
> interfce somewhat. This improvement to DERBY-2108 is described in the
> attached functional specification. See the attachment for details.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
