[ 
https://issues.apache.org/jira/browse/DERBY-2264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12474813
 ] 

Rick Hillegas commented on DERBY-2264:
--------------------------------------

Thanks for the patch, Dag. Committed DERBY-2264-1.diff at subversion revision 
510173. The patch looks solid to me and derbyall passes cleanly.

Two small points, which you may or may not want to address in a future patch:

1) Grammar: I think that the new error message would read better if you put 
another "the" in the second sentence. So: "Only the database owner can perform 
this operation."

2) Style: In DboPowersTest.dboSuite(), the magic array size 3 could be replaced 
with a constant.


> Restrict shutdown, upgrade, and encryption powers to the database owner
> -----------------------------------------------------------------------
>
>                 Key: DERBY-2264
>                 URL: https://issues.apache.org/jira/browse/DERBY-2264
>             Project: Derby
>          Issue Type: New Feature
>          Components: Security, SQL
>            Reporter: Rick Hillegas
>         Assigned To: Dag H. Wanvik
>         Attachments: dbaPowers.html, dbaPowers.html, DERBY-2264-1.diff, 
> DERBY-2264-1.stat, encrypt-1b.sql, encrypt-2.sql, encrypt-3.sql
>
>
> This JIRA separates out the database-owner powers from the system privileges 
> in the master security JIRA DERBY-2109. Restrict the following powers to the 
> database owner for the moment: shutdown, upgrade, and encryption.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to