[ 
https://issues.apache.org/jira/browse/DERBY-2283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477456
 ] 

Daniel John Debrunner commented on DERBY-2283:
----------------------------------------------

I was going to add a test case for a change in the cursor statement to this 
test but then I realized that the fixture testbug4395(0 was doing exactly that 
though its name did not indicate that and its javadoc comments did not describe 
what it is testing. I cleaned it up with revision 513967.

Looking in detail at the test I see that even though it is testing UPDATE and 
DELETE WHERE CURRENT OF it only checks that the update counts are correct after 
an execution, not that the right values were updated or the right row deleted. 
I think this is because the old test would have tested the output be comparing 
it to the master file, something to watch out for when converting tests.

Also the testUpdate() has a whole set of tests that are testing if a read only 
statement results in a null cursor name. These tests are not specific to UPDATE 
so ideally would be in their own fixture.

> convert lang/currentof.java test to junit test
> ----------------------------------------------
>
>                 Key: DERBY-2283
>                 URL: https://issues.apache.org/jira/browse/DERBY-2283
>             Project: Derby
>          Issue Type: Test
>            Reporter: Manjula Kutty
>         Assigned To: Manjula Kutty
>            Priority: Minor
>             Fix For: 10.3.0.0
>
>         Attachments: _Suite.java, CurrentOfTest.java, jira_2283_.diff.txt, 
> jira_2283_02_08_diff.txt, jira_2283_02_08_stat.txt, jira_2283_stat.txt, 
> svn_diff_02_02.txt, svn_stat_02_02.txt
>
>
> Using this Jira entry to attach the converted test in future

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to