[ 
https://issues.apache.org/jira/browse/DERBY-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477596
 ] 

Mamta A. Satoor commented on DERBY-2336:
----------------------------------------

Dan, actually thinking more about it, I think it is not enough to make the 
simple change of adding getLocaleFinder() method to ContextManager, because it 
means that we are still relying on Database Context to set the LocaleFinder 
information on the ContextManager. At recovery time(if I understand the restart 
recovery logic correctly), there will be no DatabaseContext and hence there 
will be no way to put the correct LocaleFinder info into ContextManager through 
the DatabaseContext. But store context is available at recovery time and hence 
we can have the store context do the LocaleFinder setting in the ContextManager.

If we do go with store context approach, I recognize that there does exist a 
problem for storeless engine case that you mentioned because there is no store 
context in such a case and hence LocaleFinder info will never get set into 
ContextManager. 

So, in order to solve the 2 problems ie 1)storeless engine and 2)the recovery 
time case, maybe we can duplicate the code for setting the LocaleFinder in both 
DatabaseContext and Store context so we are covered in both cases. Code 
duplicatiion is generally not a good idea but this can be an intermediate 
solution for now. Maybe it can be tackled as a separate Jira issue. 

> Enable collation based ordering for CHAR data type.
> ---------------------------------------------------
>
>                 Key: DERBY-2336
>                 URL: https://issues.apache.org/jira/browse/DERBY-2336
>             Project: Derby
>          Issue Type: Sub-task
>          Components: SQL
>    Affects Versions: 10.3.0.0
>            Reporter: Mamta A. Satoor
>         Attachments: DERBY_LocalFinder_CodeCleanup_diff_V01.txt, 
> DERBY_LocalFinder_CodeCleanup_stat_V01.txt
>
>
> I am breaking down the Parent task DERBY-1478 (Add built in language based 
> ordering and like processing to Derby) into multiple sub tasks. One of them 
> is to concentrate on enabling the collation based ordering on (hopefully the 
> simplest of all the character data types) CHAR data type. This task in itself 
> might need subtasks if it is later found that it can be subdivided into 
> multiple smaller steps.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to