[
https://issues.apache.org/jira/browse/DERBY-2257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478067
]
Knut Anders Hatlen commented on DERBY-2257:
-------------------------------------------
Thanks for addressing my previous comments. Some more questions:
- In previous versions of the patch the methods in BrokeredConnection
forwarded calls to the underlying connection, but in v6 these methods are
empty. Was that an intended change?
- Should there have been a message for LOB_LOCATOR_INVALID = "XJ217.S" in
messages.xml?
- Some of the test cases test that certain statements fail. Wouldn't it be
better if they used assertSQLState() to make sure the failures are the ones we
expect?
- I think it would be good if the test cases called cs.close().
> Implementing the stored procedures called by the LOB related JDBC methods
> -------------------------------------------------------------------------
>
> Key: DERBY-2257
> URL: https://issues.apache.org/jira/browse/DERBY-2257
> Project: Derby
> Issue Type: Sub-task
> Components: JDBC
> Environment: All environments
> Reporter: V.Narayanan
> Assigned To: V.Narayanan
> Attachments: Expln_StoredProc_LOB.txt, Expln_StoredProc_LOB_v2.txt,
> StoredProcedure_v3.diff, StoredProcedure_v3.stat, StoredProcedure_v4.diff,
> StoredProcedure_v4.stat, StoredProcedure_v5.diff, StoredProcedure_v5.stat,
> StoredProcedure_v6.diff, StoredProcedure_v6.stat, StoredProcedures_v1.diff,
> StoredProcedures_v1.stat, StoredProcedures_v2.diff, StoredProcedures_v2.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
