[ 
https://issues.apache.org/jira/browse/DERBY-2376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478933
 ] 

Rajesh Kartha commented on DERBY-2376:
--------------------------------------

I applied the patch on trunk (the patch is with respect to the 
trunk/plugins/eclipse/org.apache.derby.ui, so need to be applied there - will 
not work from trunk, which has been the normal way of applying patches).

In any case, I applied the patch and was able to create and run the plugins. 
The fix does addess  the issue of avoiding actual jar path entries in the 
project's .classpath file.  With the new plugin the .classpath for any project 
now shows up as:

<?xml version="1.0" encoding="UTF-8"?>
<classpath>
        <classpathentry kind="src" path=""/>
        <classpathentry kind="con" 
path="org.eclipse.jdt.launching.JRE_CONTAINER"/>
        <classpathentry kind="var" 
path="ECLIPSE_HOME/plugins/org.apache.derby.core_10.2.2/derby.jar"/>
        <classpathentry kind="var" 
path="ECLIPSE_HOME/plugins/org.apache.derby.core_10.2.2/derbyclient.jar"/>
        <classpathentry kind="var" 
path="ECLIPSE_HOME/plugins/org.apache.derby.core_10.2.2/derbytools.jar"/>
        <classpathentry kind="var" 
path="ECLIPSE_HOME/plugins/org.apache.derby.core_10.2.2/derbynet.jar"/>
        <classpathentry kind="output" path=""/>
</classpath>

instead of the actual paths to these jars.

I think it would be good to add information abt this JIRA entry in the comments

+1 to commit.

We may need to update some of the screen shots in the corresponding Doc plugin 
to reflect this (separate JIRA entry). Maybe then we can consider bumping the 
versions of the UI and DOC plugins  from 1.1.0 to 1.1.1 

 

> Patch available to make .classpath entries portable - relative to ECLIPSE_HOME
> ------------------------------------------------------------------------------
>
>                 Key: DERBY-2376
>                 URL: https://issues.apache.org/jira/browse/DERBY-2376
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Eclipse Plug-in
>    Affects Versions: 10.2.2.0
>         Environment: any with eclipse
>            Reporter: Aaron Tarter
>             Fix For: 10.2.2.1
>
>         Attachments: DerbyUtils.diff, DerbyUtils.diff
>
>
> This patch modifies the DerbyUtils class to add variable entries relative to 
> ECLIPSE_HOME as described in the comments below, so that eclipse projects 
> with Derby Nature can be committed to an SCM without causing build path 
> errors. I did not think any of the derby functional tests were applicable to 
> this ui action, so I manually tested the code by trying the following:
> 1) Adding Derby Nature to a java project
> 2) Starting and stopping a database with the derby nature
> 3) Removing the Derby Nature from a java project
> The code modification is only required on the add and not on the remove since 
> the current remove looks for any entry that ends with the correct JAR names.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to