[ 
https://issues.apache.org/jira/browse/DERBY-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew McIntyre updated DERBY-2410:
-----------------------------------

    Attachment: derby-2410-pre2.diff

Attaching second early draft of the conversion for this test. All the testcases 
from grantRevoke.java have now been implemented, and all testcases in this 
patch pass, but there remain several issues to resolve:

- assertInsertPrivilege and assertUpdatePrivilege need to be implemented. 
Currently having a problem with DatabaseMetaData.getColumns for the user 
connections returning an empty ResultSet. This is the next problem I will try 
to resolve.

- I think some reworking of the rollback tests is in order. While the tests 
currently pass as expected, I think that a variant of grant() is needed that 
takes a connection so that we are certain the grants occur on the owner 
connection, so we can be certain that the rollback and commit are doing what we 
expect.

- assertTriggerPrivilege has an issue in the rollback tests where an error that 
the trigger already exists occurs. This needs investigation and may be an 
actual bug.

- variant of assertSelectPrivilege that takes an array of users to verify 
public privileges, as mentioned in previous comment

- review grantRevoke.java and make sure that no functionality tested there is 
missing from the new test

after the above have been resolved:

- move testcases over from grantRevokeDDL / grantRevokeDDL2.
- assertReferencesPrivilege implementation.

> Convert grantRevoke.java to JUnit
> ---------------------------------
>
>                 Key: DERBY-2410
>                 URL: https://issues.apache.org/jira/browse/DERBY-2410
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.3.0.0
>            Reporter: Andrew McIntyre
>         Assigned To: Andrew McIntyre
>             Fix For: 10.3.0.0
>
>         Attachments: derby-2410-pre.diff, derby-2410-pre2.diff
>
>
> Convert grantRevoke.java to JUnit. Also add test cases from grantRevokeDDL 
> and grantRevokeDDL2 SQL tests to the new GrantRevokeTest

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to