[ 
https://issues.apache.org/jira/browse/DERBY-2416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12479730
 ] 

Mamta A. Satoor commented on DERBY-2416:
----------------------------------------

Manish, thanks for your time.

Answers to your comments
1)I like your name suggestion because it is shorter but one thing to note is 
that the existing SQLChars do have collation associated with them, it's just 
that it happens to be the default collation. So, if we call the subclass as 
SQLCharWithCollation, will it cause confusion about collation requirement for 
SQLChar and the new class? 
2)As for the cut and paste, the reason behind it is we do not want to penalize 
the existing SQLChar performance by addition of this new feature. Ideally, all 
the non-default collation related information should go away from SQLChar 
because that class is supposed to work with the default collation. As a cleanup 
step we should look at cleaning up methods like getIntArray from the superclass 
SQLChar and have the new subclass deal with non-default collation. Note that 
the existing getIntArray in SQLChar gets used for national character datatypes 
related code. But since Derby doesn't support that datatype any more, we can 
get rid of getIntArray entirely from SQLChar class.

> Provide a shell for a subclass of SQLChar which will use the passed Collator 
> to do the collation rather than SQLChar's default collation of UCS_BASIC
> -----------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-2416
>                 URL: https://issues.apache.org/jira/browse/DERBY-2416
>             Project: Derby
>          Issue Type: New Feature
>          Components: SQL
>    Affects Versions: 10.3.0.0
>            Reporter: Mamta A. Satoor
>         Assigned To: Mamta A. Satoor
>         Attachments: 
> DERBY2416_NewCharClassWithDifferentCollationSupport_diff_v1.txt, 
> DERBY2416_NewCharClassWithDifferentCollationSupport_stat_v1.txt
>
>
> This jira entry is one of the tasks involved in implementing DERBY-2336.
> The existing SQLChar datatype has the Derby's default collation which is 
> UCS_BASIC defined on them. With Derby 10.3, we want to support an additional 
> collation for char datatypes which will be based on the territory. This jira 
> issue is the placeholder for creating subclass of SQLChar which will use the 
> passed Collator to do the collation. The current use of this class in Derby 
> 10.3 will be for territory based collation but this class can be used in 
> future for other kinds of collations like case-insensitive etc.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to