[
https://issues.apache.org/jira/browse/DERBY-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel John Debrunner closed DERBY-1700.
----------------------------------------
> Remove passing of closeCleanup method to every ResultSet type since only the
> top ResultSet requires it.
> -------------------------------------------------------------------------------------------------------
>
> Key: DERBY-1700
> URL: https://issues.apache.org/jira/browse/DERBY-1700
> Project: Derby
> Issue Type: Improvement
> Components: SQL
> Reporter: Daniel John Debrunner
> Assigned To: Daniel John Debrunner
> Priority: Minor
> Fix For: 10.2.1.6, 10.3.0.0
>
> Attachments: derby1700_diff_p1.txt, derby1700_diff_p2.txt,
> derby1700_diff_p3.txt
>
>
> A UNION node will generate byte code to call this method:
> NoPutResultSet getUnionResultSet(NoPutResultSet source1,
> NoPutResultSet source2,
> Activation activation,
> int resultSetNumber,
> double optimizerEstimatedRowCount,
> double optimizerEstimatedCost,
> GeneratedMethod closeCleanup)
> The closeCleanup method is passed in as null for all result sets in a tree
> except the top one. Instead of passing it on each new result set, it would be
> much more efficient to have a setCloseMethod() that is only called once for
> the top result set. Could also look at having an closeCleanup method in the
> interface and call it directly, rather than through reflection.
> This applies to any node that takes a closeCleanup method.
> Split out from DERBY-766
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
