[
https://issues.apache.org/jira/browse/DERBY-2422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482956
]
Kathey Marsden commented on DERBY-2422:
---------------------------------------
Thanks Manjula for the patch. Below are my comments.
I noticed we are not running the new HoldCursorTest does not run on JSR169. It
seems like we could run all the fixtures except testStatementsInProcedure with
JSR169.
In suite() I think the following lines have no effect and can be removed.
TestSuite suite = new TestSuite("HoldCursorTest");
suite.addTestSuite(HoldCursorTest.class);
there are several lines like:
assertTrue(11== rs2.getInt(1));
which might be clearer written as
assertEquals(11,rs2.getInt(1);
And just a nit. The utility methods for createStatement, setHoldability, and
setTransactionIsolation, seem a bit much since they are one line, but it is
fine to leave them how they are.
> convert lang/holdCursorjava.java to junit
> -----------------------------------------
>
> Key: DERBY-2422
> URL: https://issues.apache.org/jira/browse/DERBY-2422
> Project: Derby
> Issue Type: Bug
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Manjula Kutty
> Assigned To: Manjula Kutty
> Priority: Trivial
> Fix For: 10.3.0.0
>
> Attachments: DERBY-2422_diff_03_16.txt, DERBY-2422_diff_03_20.txt,
> DERBY-2422_diff_ver1.txt, DERBY-2422_diff_ver2.txt,
> DERBY-2422_stat_03_20.txt, DERBY-2422_stat_ver1.txt, DERBY-2422_stat_ver2.txt
>
>
> Place holder for the conversion of the test lang/holdCursorJava.java to junit
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
