[
https://issues.apache.org/jira/browse/DERBY-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12483365
]
A B commented on DERBY-1520:
----------------------------
> All of your comments were addressed unless noted below:
Wow, that was fast :)
This looks good. I think you have addressed all of the major issues; just a
few typos remain:
-- There are a couple of places where I see "You can use the this"; i.e. the
word "the" should be removed.
-- Sometimes there are references to "diagnostic tables" and sometimes there
are references to "diagnostics tables"--i.e. the difference is the trailing "s"
on "diagnostic". It would be good if this could be made consistent throughout
the doc.
-- I think the first example for SYSCS_DIAG.SPACE_TABLE should be changed
from:
FROM TABLE (SYSCS_DIAG.SPACE_TABLE(myspacetable))
to be
FROM TABLE (SYSCS_DIAG.SPACE_TABLE('MYTABLE'))
so that it is more consistent with the second example.
I admit that I did this review rather quickly so I may have missed something,
but aside from the above minor things I think this is looking good. Thanks for
your persistence!
> Document new SYSCS_DIAG tables
> ------------------------------
>
> Key: DERBY-1520
> URL: https://issues.apache.org/jira/browse/DERBY-1520
> Project: Derby
> Issue Type: Sub-task
> Components: Documentation
> Affects Versions: 10.2.1.6
> Reporter: Stan Bradbury
> Assigned To: Laura Stewart
> Attachments: derby1520_1.diff, derby1520_2.diff, derby1520_3.diff,
> derby1520_4.diff, derby1520_5.diff, refderby.ditamap,
> rrefsyscsdiagtables.html, rrefsyscsdiagtables.html, rrefsyscsdiagtables.html
>
>
> See comments for DERBY-571 for initial documentation discussion. The new
> tables (mapped to the old Diagnostic VTIs) are:
> The old style syntax will remain in place for 10.2, but become deprecated.
> The tables to be implemented in this change are:
> SYSCS_DIAG.LOCK_TABLE replaces org.apache.derby.diag.LockTable
> SYSCS_DIAG.STATEMENT_CACHE replaces org.apache.derby.diag.StatementCache
> SYSCS_DIAG.TRANSACTION_TABLE replaces org.apache.derby.diag.TransactionTable
> SYSCS_DIAG.ERROR_MESSAGES replaces org.apache.derby.diag.ErrorMessages
> The information about the tables can be found in the javadoc for the class
> listed above.
> That can be found at:
> http://db.apache.org/derby/javadoc/engine/
> click on the org.apache.derby.diag link in the Packages table, then select
> each class, e.g. LockTable to see the info.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
