[
https://issues.apache.org/jira/browse/DERBY-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12484013
]
V.Narayanan commented on DERBY-2379:
------------------------------------
I was reviewing this patch yesterday and had a few comments too. I have not
checked to see if the intersection of the set of comments of knut and that of
mine is a null set but I am putting it out there anyway.
My comments are mostly cosmetic except for the below. The attachment contains
the cosmetic issues that I identified. I was planning to send the attachment
internally only.
you are doing the below in BlobSetMethods test. Shouldn't one of them have been
embeddedEncryptedSuite instead of embeddedSuite?
+ TestSuite blobSuite = new TestSuite ("blob set tests");
+ blobSuite.addTest (TestConfiguration.embeddedSuite
+ (BlobSetMethodsTest.class));
+ blobSuite.addTest (TestConfiguration.embeddedSuite
+ (BlobSetMethodsTest.class));
+ return blobSuite;
There is a similar issue in LobStreamTest.
Also you have made setLength and read synchronized but readByte and all the
write methods are not synchronized. Probably I am having this doubt because of
my not knowing the code properly but can you explain why you have done this?
The cosmetic comments I had can be ignored if you want to. I consider them
trivial. For whatever it is worth I wrote those comments in the form of a text
file and am attaching the file to this issue.
> provide encryption support for temporary files used by lob if the dara base
> is encrypted
> ----------------------------------------------------------------------------------------
>
> Key: DERBY-2379
> URL: https://issues.apache.org/jira/browse/DERBY-2379
> Project: Derby
> Issue Type: Sub-task
> Affects Versions: 10.3.0.0
> Environment: all
> Reporter: Anurag Shekhar
> Assigned To: Anurag Shekhar
> Attachments: CosmeticComments_1.txt, derby-2379.diff
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
