[ 
https://issues.apache.org/jira/browse/DERBY-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

V.Narayanan updated DERBY-2385:
-------------------------------

    Attachment: upgrade_v4.stat
                upgrade_v4.diff

> I would have thought the only change would be to pass the phase into the > 
> Changes10_3.suite() method.

I agree. 

I had earlier got confused with the PH_POST_HARD_UPGRADE phase and thought I 
should run the locator related tests in that phase also. I later realized that 
in that phase your database will not boot and the phase has been created to 
ensure that it doesn't. I had moved the Changes10_3.suite() code to enable 
addition in the PH_POST_HARD_UPGRADE phase but missed moving it back. 

It wouldn't have affected the current runs but was not a clean solution and was 
unnecessary.

I have addressed the issue in the current patch and have moved the code back.

thanx for pointing it out !

I ran the upgrade tests they passed with 87 runs as expected.

I am running junit tests to ensure no failures are there.

Pls consider the patch for reviews and comments. I will post the junit all run 
shortly.

> create the stored procedures called by LOB related JDBC methods during upgrade
> ------------------------------------------------------------------------------
>
>                 Key: DERBY-2385
>                 URL: https://issues.apache.org/jira/browse/DERBY-2385
>             Project: Derby
>          Issue Type: Task
>          Components: JDBC
>    Affects Versions: 10.3.0.0
>            Reporter: V.Narayanan
>         Assigned To: V.Narayanan
>         Attachments: upgrade_v1.diff, upgrade_v1.stat, upgrade_v2.diff, 
> upgrade_v2.stat, upgrade_v3.diff, upgrade_v3.stat, upgrade_v4.diff, 
> upgrade_v4.stat
>
>
> DataDictionaryImpl.create_10_3_LOB_Specific_functions() has to be called from 
> DD_Version.doFullUpgrade() in order to create the procedures when upgrading 
> from 10.2 or earlier versions.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to