[ 
https://issues.apache.org/jira/browse/DERBY-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487842
 ] 

Mamta A. Satoor commented on DERBY-2535:
----------------------------------------

Army, thanks for the careful review about DVF creation. BasicDatabase is the 
first one to create DVF and then it sets the locale on the DVF. Later in it's 
boot code, BasicDatabase creates LanguageConnectionFactory which causes a call 
to GenericLanguageConnectionFactory.boot. When GenericLanguageConnectionFactory 
asks Monitor to get DVF, Monitor return the already created DVF which has the 
locale set on it. So, although we see Monitor code getting called twice for 
DVF, the 2nd time around we get the same instance that was created by the first 
call.

Thanks Army for your time in reviewing the code.

> Make Locale available in DataValueFactory(DVF). This Locale object will be 
> used to construct Collator object if the user has requested territory based 
> collation.
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-2535
>                 URL: https://issues.apache.org/jira/browse/DERBY-2535
>             Project: Derby
>          Issue Type: New Feature
>          Components: SQL
>    Affects Versions: 10.3.0.0
>            Reporter: Mamta A. Satoor
>         Assigned To: Mamta A. Satoor
>         Attachments: DERBY2535_Set_Locale_On_DVF_v1_diff.txt, 
> DERBY2535_Set_Locale_On_DVF_v1_stat.txt, 
> DERBY2535_Set_Locale_On_DVF_v1_stat.txt, 
> DERBY2535_Uncomment_locale_setting_on_DVF_v1_diff.txt
>
>
> Add a new api on DVF which will make Locale object available to DVF. This new 
> api on DVF will get called by the boot method of  BasicDatabase after 
> BasicDatabase has finished booting DVF. This Locale will be either the Locale 
> obtained from the territory attribute supplied by the user on the JDBC url at 
> database create time or if user didn't provide the territory attribute at 
> database create time, then it will be set to the default JVM locale. This 
> Locale object will be used by DVF to construct the Collator object if user 
> has requested territory based collation.
> The new api will look like following
>         void setLocale(Locale localeOfTheDatabase);

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to