[
https://issues.apache.org/jira/browse/DERBY-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489096
]
Kristian Waagan commented on DERBY-2495:
----------------------------------------
Øystein, see my answers to selected questions below.
>> 3) Any reason why CallableLocatorProcedures.connection isn't final?
>No, and it looks like you have already made it final. Thanks.
Woops, this was due to sloppy committer-work... I give myself a little slap on
the hand for that one!
I was running tests with this modification, and making the constant
VARCHAR_MAXWIDTH private, and accidentally committed them. Forgot to diff the
diff.
>> 4) Can you get the value of VARCHAR_MAXWIDTH from somewhere, or use
>> an existing constant?
> As far as I know, the existing constant is only available in the
> embedded driver. Do you think I ought to make the effort to make it
> shared?
No. Although it would be better, I don't think it is worth it.
>> 5) CallableLocatorProcedures.blobTruncate could add newlines around
>> the paragraph tag.
> If I understand you correctly, you want newlines both before and after
> <p>. In other words, <p> should be put on a separate line? I will
> fix that.
I see others have done that, and I find it to be easy to read. You don't have
to do it this way of course, but I thought the tag looked a bit "lost" in its
current position.
> Create framework for calling locator related stored procedures from client
> --------------------------------------------------------------------------
>
> Key: DERBY-2495
> URL: https://issues.apache.org/jira/browse/DERBY-2495
> Project: Derby
> Issue Type: Sub-task
> Components: Network Client
> Reporter: Øystein Grøvlen
> Assigned To: Øystein Grøvlen
> Fix For: 10.3.0.0
>
> Attachments: blobframework.diff, blobframework_v2.diff,
> blobframework_v2.diff
>
>
> The client JDBC driver will need to call stored procedures (ref DERBY-2257)
> to operate on LOBs identified by locators. We should create a framework that
> implement the stored procedure calls. This way, the rest of the client code
> can call methods in this framework when needing to call the stored procedures
> without having to prepare SQL statements themselves.
> The framework should make sure that prepared statements are reused within a
> connection. Each procedure call should only be prepared once per connection.
> Since LOBs can not be parameters to stored procedures, the framework should
> make sure that calls involving a byte[] or String that does not fit in a
> VARCHAR (FOR BIT DATA), are split into several calls each operating on a
> fragment of the LOB.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
