[
https://issues.apache.org/jira/browse/DERBY-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489749
]
Daniel John Debrunner commented on DERBY-2557:
----------------------------------------------
DataValueFactory's role is as a factory for returning DataValueDescriptors not
as a general format identifier to object factory, that's the Monitor's role so
I think the interface should be limited to DVDs.
However I didn't understand the comment able needing to have code to handle
other formats in BaseMonitor. That code already exists and the patch doesn't
remove any of that code.
The advantage of only handling DVDs could be a much much simpler & clearer
implementation of the new method on DataValueFactory, basically just moving
existing code. (Roughly move the switch statement from the instance getter
implementation into a static method in DataValueFactoryImpl, use that method in
the new api method and have the instance getter call the static method).
> Provide a new interface on DataValueFactory(DVF) called
> getInstanceUsingFormatIdAndCollationType(formatId, collationType). This api
> will replace similar code in Monitor.
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2557
> URL: https://issues.apache.org/jira/browse/DERBY-2557
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.3.0.0
> Reporter: Mamta A. Satoor
> Assigned To: Mamta A. Satoor
> Attachments: DERBY2535_Return_Collator_api_On_DVD_v1_diff.txt,
> DERBY2535_Return_Collator_api_On_DVD_v1_stat.txt,
> DERBY2557_getObject_Using_CollationType_FormatID_interface_on_DVF_v1_diff.txt,
> DERBY2557_getObject_Using_CollationType_FormatID_interface_on_DVF_v1_stat.txt
>
>
> Provide a new interface, called
> getInstanceUsingFormatIdAndCollationType(formatId, collationType) on DVF.
> Store will call this interface to create empty DVD objects and then load
> these DVD objects using readExternal. For performance efficiency, when Store
> needs more of the same base DVD, then on subsequent needs, it will call
> DVD.getNewNull rather than calling
> DVF.getInstanceUsingFormatIdAndCollationType again. This work is required for
> DERBY-2537.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
