Myrna van Lunteren wrote:
I wonder, is your patch accidentally also solving https://issues.apache.org/jira/browse/DERBY-2559?
No such luck. I commented out the "bail out" code for DERBY-2559 in jdbcapi/DataSourceReferenceTest.java and it failed with an NPE, even with the DERBY-2488 patch applied.
But just pointing out that part of test DataSourceReferenceTest currently is not running with JDBC4 jvms.
Thanks for the heads up. I'm going to operate on the assumption that if all tests which passed without DERBY-2488 also pass with it, then the DERBY-2488 changes are okay to commit. If this proves to be an invalid assumption once DERBY-2559 has been resolved, then I will of course work to rectify the situation :)
Running tests with DERBY-2488 now... Army
