[
https://issues.apache.org/jira/browse/DERBY-2496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12492390
]
Rick Hillegas commented on DERBY-2496:
--------------------------------------
Am running regression tests against blog_v2.diff now.
The patch looks good to me. I have a couple small nits, none of which would
block me from committing this work:
1) In the header comment for BlobLocatorOutputStream, I don't understand the
reference to ByteArrayInputStream
2) There are several places in the code where the magic number -1 is used. For
instance, the initialization of Lob.locator_. I think it would be more readable
and less brittle if this magic number had a friendly name.
3) I wonder if Lob.getLocatorLength() should be abstract and the appropriate
subclass could just throw an unimplementedFeature exception right now. It looks
to me as though it would be a coding error if, in the released product, a -1
leaked out of this method.
> Implement Blob support for Locators
> -----------------------------------
>
> Key: DERBY-2496
> URL: https://issues.apache.org/jira/browse/DERBY-2496
> Project: Derby
> Issue Type: Sub-task
> Reporter: Øystein Grøvlen
> Assigned To: Øystein Grøvlen
> Attachments: blob.diff, blob_v2.diff
>
>
> DERBY-2347 adds the possibility to send locators between client and server
> instead of LOB values. This has not been activated yet, since the client
> implementation does not currently support locators. This report is for
> supporting the locators for Blob objects. Another JIRA issue will be made
> for Clob.
> This work will be made in several steps:
> 1. Blob methods and ResultSet.getXXX methods
> 2. PreparedStatement and CallableStatement methods
> 3. ResultSet.updateXXX methods
> 4. Connection.createBlob()
> There is dependencies between these steps and it might be that the Locator
> implementation cannot be exposed until everything has been done. At least,
> doing just step 1, gives testing errors because tests use Blobs fetched from
> DB as parameters to prepared statements. I would guess tests for updatable
> result sets, needs the combination of 1. and 3.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
