[ 
https://issues.apache.org/jira/browse/DERBY-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12493062
 ] 

V.Narayanan commented on DERBY-2385:
------------------------------------

>I have one question, which won't prevent me from committing this good, 
>incremental work: In Chnages10_3.testImportExportLobsProcedures(), why >is the 
>PH_POST_SOFT_UPGRADE case a NOP? Shouldn't this case have the same behavior as 
>PH_SOFT_UPGRADE? 

I have not changed anything related to this code. These changes don't seem to 
be part of this patch Rick. 

The only changes to Changes10_3.java in my patch is this

+   
+    /**
+     * Return the suite of tests to test the changes made in 10.3.
+     * @param phase an integer that indicates the current phase in
+     *              the upgrade test.
+     * @return the test suite created.
+     */   
+    public static Test suite(int phase) {
         TestSuite suite = new TestSuite("Upgrade changes for 10.3");
         
         suite.addTestSuite(Changes10_3.class);
+        
+        //Add the tests for the Stored procedures related to the locator
+        //implementation of the LOB related JDBC methods. This needs to be done
+        //only during the hard(full) upgrade phase.
+        if(phase == PH_HARD_UPGRADE) {
+            //Tests for the Blob related locator StoredProcedures
+            suite.addTestSuite(BlobStoredProcedureTest.class);
+            //Tests for the Clob related locator StoredProcedures
+            suite.addTestSuite(ClobStoredProcedureTest.class);
+        }
+        

> create the stored procedures called by LOB related JDBC methods during upgrade
> ------------------------------------------------------------------------------
>
>                 Key: DERBY-2385
>                 URL: https://issues.apache.org/jira/browse/DERBY-2385
>             Project: Derby
>          Issue Type: Task
>          Components: JDBC
>    Affects Versions: 10.3.0.0
>            Reporter: V.Narayanan
>         Assigned To: V.Narayanan
>         Attachments: upgrade_v1.diff, upgrade_v1.stat, upgrade_v2.diff, 
> upgrade_v2.stat, upgrade_v3.diff, upgrade_v3.stat, upgrade_v4.diff, 
> upgrade_v4.stat
>
>
> DataDictionaryImpl.create_10_3_LOB_Specific_functions() has to be called from 
> DD_Version.doFullUpgrade() in order to create the procedures when upgrading 
> from 10.2 or earlier versions.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to