[
https://issues.apache.org/jira/browse/DERBY-2222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jørgen Løland updated DERBY-2222:
---------------------------------
Derby Info: (was: [Patch Available])
Thanks for reviewing the patch, Kristian.
I have made a new patch that will supersed (2), and will attach it as soon as
the tests have terminated. The patch addresses your comments:
1-4) Fixed
5) Ohh... forgot these! Thanks. The methods are modified in the new patch.
6) I know, but I considered it better to continue the naming convention used
for ij*.java files. Not changed.
7) You are right, and as far as i can tell the other tests in ij7.sql are
performed only in embedded mode as well. I will start a subtask to address this.
Kristian Waagan (JIRA) wrote:
> I'm considering committing the v2 patch, but have a few comments. The tests
> run cleanly, so the comments are more like nits.
>
> 1) Some new code seem to be mixing tabs and spaces for indentation. The
> current guidelines can be found here:
> http://www.nabble.com/-VOTE---Approve-coding-conventions-for-the-Derby-project-p5771191.html.
> I always use spaces if I change more than a few consecutive lines, even if
> the rest of the file has tabs.
>
> 2) Lines longer than 80 characters.
>
> 3) The name of the methods 'getDisplayColumns' and 'getColumnWidths' are
> very generic, where as their comments indicate they are special methods that
> are only used for displaying index information. Can the names or the comments
> be changed (as appropriate) to be more in agreement?
>
> 4) The comment " //TODO: may want to change tabletype" in 'ij.jj' doesn't
> make much sense to me. Do I need to study the code to figure out what it
> means, or can it be made clearer/removed?
>
> 5) For empty method bodies, it might be nice with a one-liner explaining why
> it is empty. For instance, I assume the method 'clearSQLWarnings' in
> 'ijMultipleResultSetResult.java' is a no-op because it can't get any warnings.
>
> 6) The class 'ijMultipleResultSetResult' does not follow common naming
> guidelines for Java classes, since the start of the name is in lower case. I
> observe that this is the case for quite a lot of the files in the java/tools
> directories.
>
> 7) I wasn't able to quickly determine if the modified test (ij7.sql) is run
> with the client driver. Do you know? I did search a derbyall_pass.txt file
> (on a run with no errors), but only found the test listed once.
> 'show indexes in SCHEMANAME' does not work with the client driver
> -----------------------------------------------------------------
>
> Key: DERBY-2222
> URL: https://issues.apache.org/jira/browse/DERBY-2222
> Project: Derby
> Issue Type: Bug
> Components: Network Client, Tools
> Affects Versions: 10.2.2.0, 10.3.0.0
> Reporter: Kristian Waagan
> Assigned To: Jørgen Løland
> Attachments: DERBY-2222-1.diff, DERBY-2222-1.stat, DERBY-2222-2.diff,
> DERBY-2222-2.stat, ijMultipleResultSetResult.java
>
>
> The ij command 'show indexes in SCHEMANAME' does not work at all with the
> client driver.
> It does work with the embedded driver.
> Sample output from ij:
> ij> connect 'jdbc:derby://localhost/myDB;create=true';
> ij> create table test (id int primary key);
> 0 rows inserted/updated/deleted
> ij> show indexes in app;
> ERROR XJ103: Table name can not be null
> ij> show indexes from test;
> TABLE_NAME |COLUMN_NAME |NON_U&|TYPE|ASC&|CARDINA&|PAGES
> ----------------------------------------------------------------------------
> TEST |ID |0 |3 |A |NULL |NULL
> 1 row selected
> ij> show indexes from app.test;
> TABLE_NAME |COLUMN_NAME |NON_U&|TYPE|ASC&|CARDINA&|PAGES
> ----------------------------------------------------------------------------
> TEST |ID |0 |3 |A |NULL |NULL
> 1 row selected
> ij>
> Using delimited table and/or schema names does not work, but I think this is
> according to documentation.
> I.e.:
> ij> show indexes from "TEST";
> ERROR 42X01: Syntax error: Encountered "show" at line 1, column 1.
> ij> show indexes from "APP".test;
> ERROR 42X01: Syntax error: Encountered "show" at line 1, column 1.
> ij> show indexes from "APP"."TEST";
> ERROR 42X01: Syntax error: Encountered "show" at line 1, column 1.
> ij>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
