[
https://issues.apache.org/jira/browse/DERBY-2604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12494234
]
Knut Anders Hatlen commented on DERBY-2604:
-------------------------------------------
Hi Narayanan, I haven't looked at the entire patch, only
ClobLocatorInputStream.java, but I have a couple of comments:
1) readBytes() doesn't look correct to me. It takes a len parameter, which is
length in bytes, and passes it on to clobGetSubString(), which expects length
in characters. This means that the byte array returned by readBytes() might
contain more bytes than len. I cannot see that read() or read(byte[],int,int)
are prepared for this.
2) The boundary checking in read(byte[],int,int) might suffer from int
overflow. (off+len > b.length) should be replaced with (len > b.length - off).
3) clob and connection could be final, I think.
> Implement Clob support for locators
> -----------------------------------
>
> Key: DERBY-2604
> URL: https://issues.apache.org/jira/browse/DERBY-2604
> Project: Derby
> Issue Type: Sub-task
> Components: Network Server
> Reporter: V.Narayanan
> Assigned To: V.Narayanan
> Attachments: ClobLocatorWork_v1.diff, ClobLocatorWork_v1.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
