[
https://issues.apache.org/jira/browse/DERBY-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495361
]
Knut Anders Hatlen commented on DERBY-2551:
-------------------------------------------
Hi Julo,
The test looks good, but I have a couple of small comments:
1) The new file (XATransactionTest.java) is tab free with the exception of two
lines. It would be great if you could remove the tabs from them as well.
2) The test runs in both embedded and client/server mode, but it always uses
ClientXid. Is that OK?
3) If parseXid() used assertNotNull(str) and assertTrue(str.matches(...))
instead of returning null, it would be easier to see the problem if the test
fails.
4) Assert.assertTrue(xid.equals(rXid)) could be replaced with
Assert.assertEquals(xid, rXid), which provides more information if the test
fails.
5) rs, stm and conn aren't closed.
6) Using finally clauses to do clean-up might hide the actual error. If you
remove try/finally, it will still do the clean-up when the test runs
successfully (which it is supposed to do). If you think it's really needed to
have the clean-up in a finally block, I would recommend moving it to the
tearDown() method.
> Global Xid value garbled in syscs_diag.transaction_table.
> ---------------------------------------------------------
>
> Key: DERBY-2551
> URL: https://issues.apache.org/jira/browse/DERBY-2551
> Project: Derby
> Issue Type: Bug
> Components: Services
> Affects Versions: 10.3.0.0
> Reporter: Julius Stroffek
> Assigned To: Julius Stroffek
> Fix For: 10.2.2.1, 10.3.0.0
>
> Attachments: d2551-round2.diff, d2551-round2.stat, d2551.diff
>
>
> The value of global xid is dumped without leading zeros on
> GlobalTransactionId and BranchQualifier byte arrays. Thus, it is impossible
> to reconstruct the xid value from the transaction_table.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
