[ 
https://issues.apache.org/jira/browse/DERBY-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495363
 ] 

Knut Anders Hatlen commented on DERBY-1484:
-------------------------------------------

Hi Jørgen,

The patch generally looks good. My only comment is that I think you should use 
Util.generateCsSQLException() instead of PublicAPI.wrapStandardException(). The 
former will use the SQLExceptionFactory so that we get the correct SQLException 
type in the JDBC 4.0 driver. The latter always generates an EmbedSQLException, 
and comments in EmbedSQLException and StandardException indicate that it's just 
a hack for Cloudscape 3.0.1 that was supposed to be cleaned up later.

> Client and embedded behave differently when the table name is null in 
> DatabaseMetaData methods
> ----------------------------------------------------------------------------------------------
>
>                 Key: DERBY-1484
>                 URL: https://issues.apache.org/jira/browse/DERBY-1484
>             Project: Derby
>          Issue Type: Bug
>          Components: JDBC, Network Client
>    Affects Versions: 10.2.1.6, 10.3.0.0
>            Reporter: Knut Anders Hatlen
>         Assigned To: Jørgen Løland
>            Priority: Minor
>             Fix For: 10.3.0.0
>
>         Attachments: DERBY-1484-2.diff, DERBY-1484-2.stat, DERBY-1484-3.diff, 
> DERBY-1484-3.stat, DERBY-1484.diff, DERBY-1484.stat, releaseNote.html
>
>
> When giving null as table name to getBestRowIdentifier, getColumnPrivileges, 
> getIndexInfo, getVersionColumns or getPrimaryKeys, the client driver fails 
> with "SQLException: Table name can not be null". Embedded uses null as a 
> wildcard and does not fail. Embedded and client should have the same 
> behaviour.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to