[ 
https://issues.apache.org/jira/browse/DERBY-2599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12497590
 ] 

Mamta A. Satoor commented on DERBY-2599:
----------------------------------------

Army, thank you very much for reviewing my patches. 

I am getting to the stage in this project where I need to make sure that I set 
correct collation wherever we construct a DTD. So, I am very greatful for these 
reviews. And I think you have definitely found a bug in the changes I made with 
DERBY2599_Set_collation_for_aggregates_v1_diff.txt. The ? param should pickup 
it's collation from schema. I will fix that soon.


> Set correct collation type and derivation on DataTypeDescriptor(DTD).
> ---------------------------------------------------------------------
>
>                 Key: DERBY-2599
>                 URL: https://issues.apache.org/jira/browse/DERBY-2599
>             Project: Derby
>          Issue Type: New Feature
>          Components: SQL
>    Affects Versions: 10.3.0.0
>            Reporter: Mamta A. Satoor
>         Assigned To: Mamta A. Satoor
>         Attachments: DERBY2599_collationType_default_UCS_BASIC_v1_diff.txt, 
> DERBY2599_collationType_default_UCS_BASIC_v1_stat.txt, 
> DERBY2599_correct_collation_for_cast_v1_diff.txt, 
> DERBY2599_correct_collation_for_cast_v1_stat.txt, 
> DERBY2599_IntermediatePatch_v1_diff.txt, 
> DERBY2599_IntermediatePatch_v1_stat.txt, 
> DERBY2599_Set_collation_for_aggregates_v1_diff.txt, 
> DERBY2599_Set_collation_for_aggregates_v1_stat.txt, 
> DERBY2599_Set_collation_for_aggregates_v1_stat.txt, 
> DERBY2599_Set_collation_for_Max_Min_v1_diff.txt
>
>
> DTD has TypeDescriptorImpl in it which has 2 new fields, namely, 
> collationType and collationDerivation. These 2 fields are available for all 
> different types of DTDs but only apply to character types. The other 
> datatypes should ignore these 2 fields.
> This Jira is a placeholder for loading the correct values into collationType 
> and collationDerivation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to