[ 
https://issues.apache.org/jira/browse/DERBY-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12497880
 ] 

Knut Anders Hatlen commented on DERBY-2379:
-------------------------------------------

Thanks for addressing my comments, Anurag! I will take a look at the latest 
patch and commit it if the tests pass and I don't find more issues.

As to the discussion about LOBFile, even if we cannot let LOBFile implement the 
StorageFile interface, I still feel it would be cleaner to split the code for 
encrypted and non-encrypted LOBs. For instance, we could let LOBFile handle 
unencrypted LOBs, and have another class EncryptedLOBFile which extended 
LOBFile and handled the encrypted LOBs. But that could be addressed as a 
separate clean-up task later.

> provide encryption support for temporary files used by lob if the data base 
> is encrypted
> ----------------------------------------------------------------------------------------
>
>                 Key: DERBY-2379
>                 URL: https://issues.apache.org/jira/browse/DERBY-2379
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC
>    Affects Versions: 10.3.0.0
>         Environment: all
>            Reporter: Anurag Shekhar
>         Assigned To: Anurag Shekhar
>         Attachments: CosmeticComments_1.txt, derby-2379.diff, 
> derby-2379v2-conflict.diff, derby-2379v2.diff, derby-2379v3.diff
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to