[
https://issues.apache.org/jira/browse/DERBY-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12499442
]
Knut Anders Hatlen commented on DERBY-2562:
-------------------------------------------
Hi Ugo,
The patch looks good to me. A couple of tiny comments:
- I think joinStmt and distinctStmt should have been instance variables, not
static variables. With that change, you'll also need a tearDown() method which
closes those objects, sets them to null and calls super.tearDown()
- checkAllCa1() has a finally block with clean-up code. Finally blocks could
be dangerous in tests since errors that happen in the finally block will hide
errors in the try block. In this case, I think it would be OK just to remove
the try/finally.
Thanks!
> conver/SpillHash.java to JUnit
> ------------------------------
>
> Key: DERBY-2562
> URL: https://issues.apache.org/jira/browse/DERBY-2562
> Project: Derby
> Issue Type: Test
> Components: Test
> Reporter: Ugo Matrangolo
> Assigned To: Ugo Matrangolo
> Priority: Minor
> Attachments: DERBY-2562_diff_200507.txt, DERBY-2562_stat_200507.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
